dart/sdk/lib/_internal/lib/js_helper.dart - Issue 345533004: Use "self" instead of globalThis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/lib/js_helper.dart

Issue 345533004: Use "self" instead of globalThis. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Merged with r37482. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/sdk/lib/_internal/lib/js_helper.dart

diff --git a/dart/sdk/lib/_internal/lib/js_helper.dart b/dart/sdk/lib/_internal/lib/js_helper.dart

index 4fab0b2d7fcd6c205b2c2e8ff72a6988c5340960..8f87ac4f8cbdcc4871f860ed5a5ff805f8c31cf1 100644

--- a/dart/sdk/lib/_internal/lib/js_helper.dart

+++ b/dart/sdk/lib/_internal/lib/js_helper.dart

@@ -552,8 +552,6 @@ class Primitives {

return JS('int', '#', hash);

}

- static computeGlobalThis() => JS('', 'function() { return this; }()');

static _throwFormatException(String string) {

throw new FormatException(string);

}

@@ -721,7 +719,7 @@ class Primitives {

static String currentUri() {

// In a browser return self.location.href.

- if (JS('bool', 'typeof self != "undefined"')) {

+ if (JS('bool', '!!self.location')) {

return JS('String', 'self.location.href');

}