Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: dart/sdk/lib/_internal/lib/async_patch.dart

Issue 345533004: Use "self" instead of globalThis. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r37482. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/sdk/lib/_internal/lib/isolate_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/lib/async_patch.dart
diff --git a/dart/sdk/lib/_internal/lib/async_patch.dart b/dart/sdk/lib/_internal/lib/async_patch.dart
index dede2552bcd8ef04daadcd494e7869eb89f362fa..cd5890d595fd9ac4e9e875a819b9928c3a2c685b 100644
--- a/dart/sdk/lib/_internal/lib/async_patch.dart
+++ b/dart/sdk/lib/_internal/lib/async_patch.dart
@@ -14,8 +14,7 @@ import 'dart:_isolate_helper' show
TimerImpl,
leaveJsAsync,
enterJsAsync,
- isWorker,
- globalThis;
+ isWorker;
import 'dart:_foreign_helper' show JS;
@@ -46,7 +45,7 @@ class _AsyncRun {
_initializeScheduleImmediate();
static Function _initializeScheduleImmediate() {
- if (JS('', '#.scheduleImmediate', globalThis) != null) {
+ if (JS('', 'self.scheduleImmediate') != null) {
return _scheduleImmediateJsOverride;
}
// TODO(9002): don't use the Timer to enqueue the immediate callback.
@@ -60,8 +59,7 @@ class _AsyncRun {
callback();
};
enterJsAsync();
- JS('void', '#.scheduleImmediate(#)',
- globalThis,
+ JS('void', 'self.scheduleImmediate(#)',
convertDartClosureToJS(internalCallback, 0));
}
« no previous file with comments | « no previous file | dart/sdk/lib/_internal/lib/isolate_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698