Issue 34533003: VM: Always return immutable collections from the mirrors.

Issue 34533003: VM: Always return immutable collections from the mirrors. (Closed)

Created:
7 years, 2 months ago by rmacnak

Modified:
7 years, 2 months ago

Reviewers:
ahe, gbracha, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

VM: Always return immutable collections from the mirrors. Fix assert in partial demangling. Fix inappropriate compilation when handling parameters. BUG=http://dartbug.com/14027 R=ahe@google.com, asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=29030

Patch Set 1 : #

Patch Set 2 : mirrors.sh #

Total comments: 2

Patch Set 3 : #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -36 lines)			Patch
M	runtime/lib/mirrors.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1 2	16 chunks	+73 lines, -27 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/lib/mirrors/immutable_collections_test.dart	View		2 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM except that I don't understand the change to object.cc. https://codereview.chromium.org/34533003/diff/120001/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/34533003/diff/120001/runtime/lib/mirrors_impl.dart#newcode12 ...

7 years, 2 months ago (2013-10-22 18:18:09 UTC) #2

rmacnak

On 2013/10/22 18:18:09, ahe wrote: > LGTM except that I don't understand the change to ...

7 years, 2 months ago (2013-10-22 18:28:15 UTC) #3

rmacnak

https://codereview.chromium.org/34533003/diff/160001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/34533003/diff/160001/runtime/vm/object.cc#newcode334 runtime/vm/object.cc:334: ASSERT(!is_setter || (at_pos == -1)); This change allows for ...

7 years, 2 months ago (2013-10-22 18:32:51 UTC) #4

rmacnak

7 years, 2 months ago (2013-10-22 19:53:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r29030 (presubmit successful).

Expand Messages | Collapse Messages