runtime/vm/object.cc - Issue 34533003: VM: Always return immutable collections from the mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 34533003: VM: Always return immutable collections from the mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 34a530792daf74bbf15f65d4950af01d612b0080..0f3c7054de0e7669eae1777a5b517df6710da3ab 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -330,7 +330,8 @@ RawString* String::IdentifierPrettyNameRetainPrivate(const String& name) {

}

start = i + 1;

} else if (name.CharAt(i) == '@') {

- ASSERT(at_pos == -1); // Only one @ is supported.

+ // Setters should have only one @ so we know where to put the =.

+ ASSERT(!is_setter || (at_pos == -1));

rmacnak 2013/10/22 18:32:52 This change allows for names of the form _Private

at_pos = i;

}

« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »