sdk/lib/_internal/lib/js_mirrors.dart - Issue 34533003: VM: Always return immutable collections from the mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 34533003: VM: Always return immutable collections from the mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/lib/js_mirrors.dart

diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart

index 3ef7beb8ab8f0ebfa6d101fc13237e8d0ec68842..e5d73b04329280aa3c0c20c4520ac5cfe7852b44 100644

--- a/sdk/lib/_internal/lib/js_mirrors.dart

+++ b/sdk/lib/_internal/lib/js_mirrors.dart

@@ -1917,7 +1917,7 @@ bool isReflectiveDataInPrototype(String key) {

}

// Copied from package "unmodifiable_collection".

-// TODO(ahe): Lobby to get it added to dart:collection.

+// TODO(14314): Move to dart:collection.

class UnmodifiableMapView<K, V> implements Map<K, V> {

Map<K, V> _source;

UnmodifiableMapView(Map<K, V> source) : _source = source;

« runtime/vm/object.cc ('K') | « runtime/vm/object.cc ('k') | tests/lib/lib.status » ('j') | no next file with comments »