Issue 342283004: Address issues found with analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 342283004: Address issues found with analyzer (Closed)

Created:
6 years, 6 months ago by ahe

Modified:
6 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Address issues found with analyzer R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=37600

Patch Set 2 : Merged with r37597. #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -20 lines)			Patch
M	dart/site/try/src/Makefile	View		1 chunk	+5 lines, -0 lines	2 comments	Download
M	dart/site/try/src/caching_compiler.dart	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	dart/site/try/src/compilation.dart	View		2 chunks	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/342283004/diff/20001/dart/site/try/src/Makefile File dart/site/try/src/Makefile (right): https://codereview.chromium.org/342283004/diff/20001/dart/site/try/src/Makefile#newcode18 dart/site/try/src/Makefile:18: | awk -F'|' '{print $$4 ":" $$5 ":" ...

6 years, 6 months ago (2014-06-23 13:02:45 UTC) #3

ahe

Thank you, Kasper! https://codereview.chromium.org/342283004/diff/20001/dart/site/try/src/Makefile File dart/site/try/src/Makefile (right): https://codereview.chromium.org/342283004/diff/20001/dart/site/try/src/Makefile#newcode18 dart/site/try/src/Makefile:18: | awk -F'|' '{print $$4 ":" ...

6 years, 6 months ago (2014-06-23 13:24:05 UTC) #4

ahe

6 years, 6 months ago (2014-06-23 13:24:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r37600 (presubmit successful).

Expand Messages | Collapse Messages

Issue 342283004: Address issues found with analyzer (Closed)

Description

Patch Set 1 #

Patch Set 2 : Merged with r37597. #

Messages