Chromium Code Reviews Chromium Code Reviews
Issue 342283004:
Address issues found with analyzer (Closed)
Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file | 1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file |
| 2 # for details. All rights reserved. Use of this source code is governed by a | 2 # for details. All rights reserved. Use of this source code is governed by a |
| 3 # BSD-style license that can be found in the LICENSE file. | 3 # BSD-style license that can be found in the LICENSE file. |
| 4 | 4 |
| 5 SDK_DIR=../../../xcodebuild/ReleaseIA32/dart-sdk | 5 SDK_DIR=../../../xcodebuild/ReleaseIA32/dart-sdk |
| 6 PACKAGE_ROOT=../../../sdk/lib/_internal/ | 6 PACKAGE_ROOT=../../../sdk/lib/_internal/ |
| 7 | 7 |
| 8 all: | 8 all: |
| 9 $(SDK_DIR)/bin/dartanalyzer -p $(PACKAGE_ROOT) \ | 9 $(SDK_DIR)/bin/dartanalyzer -p $(PACKAGE_ROOT) \ |
| 10 --package-warnings --machine leap.dart 2>&1 \ | 10 --package-warnings --machine leap.dart 2>&1 \ |
| 11 | grep -v DEPRECATED_MEMBER_USE \ | 11 | grep -v DEPRECATED_MEMBER_USE \ |
| 12 | sed -e "s,$(PWD)/,," \ | 12 | sed -e "s,$(PWD)/,," \ |
| 13 | awk -F'|' '{print $$4 ":" $$5 ":" $$6 ": [" $$3 "] " $$8 }' | 13 | awk -F'|' '{print $$4 ":" $$5 ":" $$6 ": [" $$3 "] " $$8 }' |
| 14 $(SDK_DIR)/bin/dartanalyzer -p $(PACKAGE_ROOT) \ | |
| 15 --package-warnings --machine compiler_isolate.dart 2>&1 \ | |
| 16 | grep -v DEPRECATED_MEMBER_USE \ | |
| 17 | sed -e "s,$(PWD)/,," \ | |
| 18 | awk -F'|' '{print $$4 ":" $$5 ":" $$6 ": [" $$3 "] " $$8 }' | |
|
kasperl
2014/06/23 13:02:45
It's a bit painful to see this duplication.
ahe
2014/06/23 13:24:05
Yes, but Makefile macros are even more painful :-(
| |
| OLD | NEW |
