Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: dart/site/try/src/Makefile

Issue 342283004: Address issues found with analyzer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r37597. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/site/try/src/caching_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/site/try/src/Makefile
diff --git a/dart/site/try/src/Makefile b/dart/site/try/src/Makefile
index d21996bdbee2476628c91b9ddd05860bcb1dd2a9..763086213fe84b1eb22ea6099250b41b10675f87 100644
--- a/dart/site/try/src/Makefile
+++ b/dart/site/try/src/Makefile
@@ -11,3 +11,8 @@ all:
| grep -v DEPRECATED_MEMBER_USE \
| sed -e "s,$(PWD)/,," \
| awk -F'|' '{print $$4 ":" $$5 ":" $$6 ": [" $$3 "] " $$8 }'
+ $(SDK_DIR)/bin/dartanalyzer -p $(PACKAGE_ROOT) \
+ --package-warnings --machine compiler_isolate.dart 2>&1 \
+ | grep -v DEPRECATED_MEMBER_USE \
+ | sed -e "s,$(PWD)/,," \
+ | awk -F'|' '{print $$4 ":" $$5 ":" $$6 ": [" $$3 "] " $$8 }'
kasperl 2014/06/23 13:02:45 It's a bit painful to see this duplication.
ahe 2014/06/23 13:24:05 Yes, but Makefile macros are even more painful :-(
« no previous file with comments | « no previous file | dart/site/try/src/caching_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698