Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 339593002: Fix bug in ARM instance field stores. (Closed)

Created:
6 years, 6 months ago by Florian Schneider
Modified:
6 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix bug in ARM instance field stores. A large number of fields resulted in wrong offset computation for the generated code for stores. BUG=dartbug.com/19649 TEST=tests/language/large_class_declaration_test.dart R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=37389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5083 lines, -21 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 3 chunks +41 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 5 chunks +13 lines, -20 lines 0 comments Download
A tests/language/large_class_declaration_test.dart View 1 chunk +5018 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Florian Schneider
6 years, 6 months ago (2014-06-16 12:46:34 UTC) #1
zra
lgtm
6 years, 6 months ago (2014-06-16 16:21:01 UTC) #2
zra
On 2014/06/16 16:21:01, zra wrote: > lgtm It looks like the same problem exists on ...
6 years, 6 months ago (2014-06-16 18:40:36 UTC) #3
Florian Schneider
On 2014/06/16 18:40:36, zra wrote: > On 2014/06/16 16:21:01, zra wrote: > > lgtm > ...
6 years, 6 months ago (2014-06-17 09:25:29 UTC) #4
Florian Schneider
6 years, 6 months ago (2014-06-17 09:28:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r37389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698