Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 339593002: Fix bug in ARM instance field stores. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 931 matching lines...) Expand 10 before | Expand all | Expand 10 after
942 942
943 943
944 void FlowGraphCompiler::GenerateInlinedSetter(intptr_t offset) { 944 void FlowGraphCompiler::GenerateInlinedSetter(intptr_t offset) {
945 // LR: return address. 945 // LR: return address.
946 // SP+1: receiver. 946 // SP+1: receiver.
947 // SP+0: value. 947 // SP+0: value.
948 // Sequence node has one store node and one return NULL node. 948 // Sequence node has one store node and one return NULL node.
949 __ Comment("Inlined Setter"); 949 __ Comment("Inlined Setter");
950 __ ldr(R0, Address(SP, 1 * kWordSize)); // Receiver. 950 __ ldr(R0, Address(SP, 1 * kWordSize)); // Receiver.
951 __ ldr(R1, Address(SP, 0 * kWordSize)); // Value. 951 __ ldr(R1, Address(SP, 0 * kWordSize)); // Value.
952 __ StoreIntoObject(R0, FieldAddress(R0, offset), R1); 952 __ StoreIntoObjectOffset(R0, offset, R1);
953 __ LoadImmediate(R0, reinterpret_cast<intptr_t>(Object::null())); 953 __ LoadImmediate(R0, reinterpret_cast<intptr_t>(Object::null()));
954 __ Ret(); 954 __ Ret();
955 } 955 }
956 956
957 957
958 void FlowGraphCompiler::EmitFrameEntry() { 958 void FlowGraphCompiler::EmitFrameEntry() {
959 const Function& function = parsed_function().function(); 959 const Function& function = parsed_function().function();
960 if (CanOptimizeFunction() && 960 if (CanOptimizeFunction() &&
961 function.IsOptimizable() && 961 function.IsOptimizable() &&
962 (!is_optimizing() || may_reoptimize())) { 962 (!is_optimizing() || may_reoptimize())) {
(...skipping 799 matching lines...) Expand 10 before | Expand all | Expand 10 after
1762 DRegister dreg = EvenDRegisterOf(reg); 1762 DRegister dreg = EvenDRegisterOf(reg);
1763 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1763 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1764 } 1764 }
1765 1765
1766 1766
1767 #undef __ 1767 #undef __
1768 1768
1769 } // namespace dart 1769 } // namespace dart
1770 1770
1771 #endif // defined TARGET_ARCH_ARM 1771 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698