Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 339593002: Fix bug in ARM instance field stores. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | tests/language/large_class_declaration_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm.cc
===================================================================
--- runtime/vm/intermediate_language_arm.cc (revision 37311)
+++ runtime/vm/intermediate_language_arm.cc (working copy)
@@ -1956,9 +1956,7 @@
temp2);
__ Bind(slow_path->exit_label());
__ MoveRegister(temp2, temp);
- __ StoreIntoObject(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
- temp2);
+ __ StoreIntoObjectOffset(instance_reg, offset_in_bytes_, temp2);
} else {
__ ldr(temp, FieldAddress(instance_reg, offset_in_bytes_));
}
@@ -2043,9 +2041,7 @@
temp2);
__ Bind(slow_path->exit_label());
__ MoveRegister(temp2, temp);
- __ StoreIntoObject(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
- temp2);
+ __ StoreIntoObjectOffset(instance_reg, offset_in_bytes_, temp2);
__ Bind(&copy_double);
__ CopyDoubleField(temp, value_reg, TMP, temp2, fpu_temp);
__ b(&skip_store);
@@ -2069,9 +2065,7 @@
temp2);
__ Bind(slow_path->exit_label());
__ MoveRegister(temp2, temp);
- __ StoreIntoObject(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
- temp2);
+ __ StoreIntoObjectOffset(instance_reg, offset_in_bytes_, temp2);
__ Bind(&copy_float32x4);
__ CopyFloat32x4Field(temp, value_reg, TMP, temp2, fpu_temp);
__ b(&skip_store);
@@ -2095,9 +2089,7 @@
temp2);
__ Bind(slow_path->exit_label());
__ MoveRegister(temp2, temp);
- __ StoreIntoObject(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
- temp2);
+ __ StoreIntoObjectOffset(instance_reg, offset_in_bytes_, temp2);
__ Bind(&copy_float64x2);
__ CopyFloat64x2Field(temp, value_reg, TMP, temp2, fpu_temp);
__ b(&skip_store);
@@ -2108,20 +2100,21 @@
if (ShouldEmitStoreBarrier()) {
const Register value_reg = locs()->in(1).reg();
- __ StoreIntoObject(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
- value_reg,
- CanValueBeSmi());
+ __ StoreIntoObjectOffset(instance_reg,
+ offset_in_bytes_,
+ value_reg,
+ CanValueBeSmi());
} else {
if (locs()->in(1).IsConstant()) {
- __ StoreIntoObjectNoBarrier(
+ __ StoreIntoObjectNoBarrierOffset(
instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_),
+ offset_in_bytes_,
locs()->in(1).constant());
} else {
const Register value_reg = locs()->in(1).reg();
- __ StoreIntoObjectNoBarrier(instance_reg,
- FieldAddress(instance_reg, offset_in_bytes_), value_reg);
+ __ StoreIntoObjectNoBarrierOffset(instance_reg,
+ offset_in_bytes_,
+ value_reg);
}
}
__ Bind(&skip_store);
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | tests/language/large_class_declaration_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698