Issue 338683003: Extract 'DartUnitHighlightsComputer' tests into a separate file.

Issue 338683003: Extract 'DartUnitHighlightsComputer' tests into a separate file. (Closed)

Created:
6 years, 6 months ago by scheglov

Modified:
6 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Extract 'DartUnitHighlightsComputer' tests into a separate file. Use constants. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37452

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+778 lines, -1165 lines)			Patch
M	pkg/analysis_server/lib/src/computer/computer_highlights.dart	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/constants.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	pkg/analysis_server/test/analysis_notification_highlights_test.dart	View	1 chunk	+769 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/analysis_notification_navigation_test.dart	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	pkg/analysis_server/test/analysis_notification_outline_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/domain_analysis_test.dart	View	2 chunks	+0 lines, -1157 lines	0 comments	Download
M	pkg/analysis_server/test/test_all.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/338683003/diff/1/pkg/analysis_server/test/analysis_notification_navigation_test.dart File pkg/analysis_server/test/analysis_notification_navigation_test.dart (right): https://codereview.chromium.org/338683003/diff/1/pkg/analysis_server/test/analysis_notification_navigation_test.dart#newcode20 pkg/analysis_server/test/analysis_notification_navigation_test.dart:20: runReflectiveTests(_AnalysisNotificationNavigationTest); Is there any reason to make any ...

6 years, 6 months ago (2014-06-18 16:28:38 UTC) #2

scheglov

Committed patchset #1 manually as r37452 (presubmit successful).

6 years, 6 months ago (2014-06-18 16:34:23 UTC) #3

scheglov

6 years, 6 months ago (2014-06-18 16:34:47 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/338683003/diff/1/pkg/analysis_server/test/ana...
File pkg/analysis_server/test/analysis_notification_navigation_test.dart
(right):

https://codereview.chromium.org/338683003/diff/1/pkg/analysis_server/test/ana...
pkg/analysis_server/test/analysis_notification_navigation_test.dart:20:
runReflectiveTests(_AnalysisNotificationNavigationTest);
On 2014/06/18 16:28:37, Brian Wilkerson wrote:
> Is there any reason to make any test code private? Seems pointless, but I
don't
> have a problem with it.

I do it by the same reasons as for the all code - to show that this code is not
used outside of its library.
I don't have a strong preference, it just makes the code slightly easier to
understand.

Expand Messages | Collapse Messages