Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: pkg/analysis_server/test/analysis_notification_navigation_test.dart

Issue 338683003: Extract 'DartUnitHighlightsComputer' tests into a separate file. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.domain.analysis.notification.navigation; 5 library test.domain.analysis.notification.navigation;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/src/analysis_server.dart'; 9 import 'package:analysis_server/src/analysis_server.dart';
10 import 'package:analysis_server/src/constants.dart'; 10 import 'package:analysis_server/src/constants.dart';
11 import 'package:analysis_server/src/protocol.dart'; 11 import 'package:analysis_server/src/protocol.dart';
12 import 'package:unittest/unittest.dart'; 12 import 'package:unittest/unittest.dart';
13 13
14 import 'analysis_abstract.dart'; 14 import 'analysis_abstract.dart';
15 import 'reflective_tests.dart'; 15 import 'reflective_tests.dart';
16 16
17 17
18 main() { 18 main() {
19 group('notification.navigation', () { 19 group('notification.navigation', () {
20 runReflectiveTests(AnalysisNotificationNavigationTest); 20 runReflectiveTests(_AnalysisNotificationNavigationTest);
Brian Wilkerson 2014/06/18 16:28:37 Is there any reason to make any test code private?
scheglov 2014/06/18 16:34:47 I do it by the same reasons as for the all code -
21 }); 21 });
22 } 22 }
23 23
24 24
25 @ReflectiveTestCase() 25 @ReflectiveTestCase()
26 class AnalysisNotificationNavigationTest extends AbstractAnalysisTest { 26 class _AnalysisNotificationNavigationTest extends AbstractAnalysisTest {
27 List<_NavigationRegion> regions; 27 List<_NavigationRegion> regions;
28 _NavigationRegion testRegion; 28 _NavigationRegion testRegion;
29 List<_NavigationTarget> testTargets; 29 List<_NavigationTarget> testTargets;
30 30
31 @override 31 @override
32 void setUp() { 32 void setUp() {
33 super.setUp(); 33 super.setUp();
34 createProject(); 34 createProject();
35 } 35 }
36 36
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 } 454 }
455 455
456 456
457 class _NavigationTarget { 457 class _NavigationTarget {
458 final String file; 458 final String file;
459 final int offset; 459 final int offset;
460 final int length; 460 final int length;
461 461
462 _NavigationTarget(this.file, this.offset, this.length); 462 _NavigationTarget(this.file, this.offset, this.length);
463 } 463 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698