pkg/analysis_server/test/analysis_notification_navigation_test.dart - Issue 338683003: Extract 'DartUnitHighlightsComputer' tests into a separate file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/analysis_notification_navigation_test.dart

Issue 338683003: Extract 'DartUnitHighlightsComputer' tests into a separate file. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/analysis_notification_highlights_test.dart ('k') | pkg/analysis_server/test/analysis_notification_outline_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/analysis_notification_navigation_test.dart

diff --git a/pkg/analysis_server/test/analysis_notification_navigation_test.dart b/pkg/analysis_server/test/analysis_notification_navigation_test.dart

index e87a42c2b1ee6a8cfe6b75270cbfba19ed3d4d84..c2b7b7e338a51fce27f759a3564c365b1792c13f 100644

--- a/pkg/analysis_server/test/analysis_notification_navigation_test.dart

+++ b/pkg/analysis_server/test/analysis_notification_navigation_test.dart

@@ -17,13 +17,13 @@ import 'reflective_tests.dart';

main() {

group('notification.navigation', () {

- runReflectiveTests(AnalysisNotificationNavigationTest);

+ runReflectiveTests(_AnalysisNotificationNavigationTest);

Brian Wilkerson 2014/06/18 16:28:37 Is there any reason to make any test code private?

scheglov 2014/06/18 16:34:47 I do it by the same reasons as for the all code -

});

}

@ReflectiveTestCase()

-class AnalysisNotificationNavigationTest extends AbstractAnalysisTest {

+class _AnalysisNotificationNavigationTest extends AbstractAnalysisTest {

List<_NavigationRegion> regions;

_NavigationRegion testRegion;

List<_NavigationTarget> testTargets;