Add missing demangling to the VM's NoSuchMethodError. Ensure the NoSuchMethorError for reflective i…

Add missing demangling to the VM's NoSuchMethodError. Ensure the VM's NoSuchMethorErrors for reflective invocation match those for non-reflective invocation.

Fix bug in VM demangling of setters.
Fix bug where test was not covering invocation on classes as intended.

BUG=http://dartbug.com/18042
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37294

[siva, 2014-06-12 16:59:07]

LGTM with some comments.

https://codereview.chromium.org/326263002/diff/60001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/326263002/diff/60001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:662: Array::Handle(),
Use Object::null_array() instead of creating a new empty handle

https://codereview.chromium.org/326263002/diff/60001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:700: Array::Handle(),
Ditto.

https://codereview.chromium.org/326263002/diff/60001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:1430: Array::Handle(),
Ditto here and other places below.

https://codereview.chromium.org/326263002/diff/60001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:1708: return call_result.raw();
Indentation of this block seems off.

https://codereview.chromium.org/326263002/diff/60001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/326263002/diff/60001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:8056: String::ZoneHandle(Field::SetterName(name)),
Why does it have to be a ZoneHandle just a regular handle should be fine here.

[rmacnak, 2014-06-12 22:52:08]

https://codereview.chromium.org/326263002/diff/60001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/326263002/diff/60001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:662: Array::Handle(),
On 2014/06/12 16:59:07, siva wrote:
> Use Object::null_array() instead of creating a new empty handle

Done.

https://codereview.chromium.org/326263002/diff/60001/runtime/lib/mirrors.cc#n...
runtime/lib/mirrors.cc:1708: return call_result.raw();
On 2014/06/12 16:59:07, siva wrote:
> Indentation of this block seems off.

Fixed.

https://codereview.chromium.org/326263002/diff/60001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/326263002/diff/60001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:8056: String::ZoneHandle(Field::SetterName(name)),
On 2014/06/12 16:59:07, siva wrote:
> Why does it have to be a ZoneHandle just a regular handle should be fine here.

Ok, ThrowNoSuchMethod creates its own zone handle after interning. Switched to a
regular handle.

[rmacnak, 2014-06-12 22:53:07]

Committed patchset #5 manually as r37294 (presubmit successful).