Add missing demangling to the VM's NoSuchMethodError. Ensure the NoSuchMethorError for reflective i…

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "lib/invocation_mirror.h"
 #include "platform/utils.h"
 #include "vm/bootstrap.h"
 #include "vm/class_finalizer.h"
@@ skipping 8035 matching lines @@
                (original->IsLiteralNode() ||
                 original->IsLoadLocalNode())) {
       name = left_ident->raw();
     }
     if (name.IsNull()) {
       ErrorMsg(left_pos, "expression is not assignable");
     }
     result = ThrowNoSuchMethodError(
         original->token_pos(),
         *target_cls,
-        name,
+        String::ZoneHandle(Field::SetterName(name)),

[siva, 2014/06/12 16:59:07]

Why does it have to be a ZoneHandle just a regular handle should be fine here.

[rmacnak, 2014/06/12 22:52:08]

Ok, ThrowNoSuchMethod creates its own zone handle after interning. Switched to a
regular handle.

         NULL,  // No arguments.
         InvocationMirror::kStatic,
         original->IsLoadLocalNode() ?
             InvocationMirror::kLocalVar : InvocationMirror::kSetter,
         NULL);  // No existing function.
   } else if (result->IsStoreIndexedNode() ||
              result->IsInstanceSetterNode() ||
              result->IsStaticSetterNode() ||
              result->IsStoreStaticFieldNode() ||
              result->IsStoreLocalNode()) {
@@ skipping 2968 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart