Add missing demangling to the VM's NoSuchMethodError. Ensure the NoSuchMethorError for reflective i…

tests/lib/mirrors/mirrors_nsm_test.dart

Index: tests/lib/mirrors/mirrors_nsm_test.dart
diff --git a/tests/lib/mirrors/mirrors_nsm_test.dart b/tests/lib/mirrors/mirrors_nsm_test.dart
index 88ad27c468b5c59a6cee3236fe333233946c181e..f1abaa76605e747b3444a47a1bb7373da51fbfe1 100644
--- a/tests/lib/mirrors/mirrors_nsm_test.dart
+++ b/tests/lib/mirrors/mirrors_nsm_test.dart
@@ -15,25 +15,33 @@ bool isNSMContainingFieldName(e, String fieldName, bool isSetter) {
   return "$e".contains(needle) && ! "$e".contains(needle + "=");
 }
 
-class A {}
+final finalTopLevel = 0;
+class A {
+  final finalInstance = 0;
+  static final finalStatic = 0;
+}
 
-main() {
+testMessageContents() {
   var mirrors = currentMirrorSystem();
   var libMirror = mirrors.findLibrary(#MirrorsTest);
   Expect.throws(() => libMirror.invoke(#foo, []),
                 (e) => isNSMContainingFieldName(e, "foo", false));
   Expect.throws(() => libMirror.getField(#foo),
                 (e) => isNSMContainingFieldName(e, "foo", false));
-  Expect.throws(() => libMirror.setField(#foo, null),             /// vm: ok
-                (e) => isNSMContainingFieldName(e, "foo", true)); /// vm: continued
+  Expect.throws(() => libMirror.setField(#foo, null),
+                (e) => isNSMContainingFieldName(e, "foo", true));
+  Expect.throws(() => libMirror.setField(#finalTopLevel, null),
+                (e) => isNSMContainingFieldName(e, "finalTopLevel", true));
 
-  var classMirror = reflect(A);
+  var classMirror = reflectClass(A);
   Expect.throws(() => classMirror.invoke(#foo, []),
                 (e) => isNSMContainingFieldName(e, "foo", false));
   Expect.throws(() => classMirror.getField(#foo),
                 (e) => isNSMContainingFieldName(e, "foo", false));
   Expect.throws(() => classMirror.setField(#foo, null),
                 (e) => isNSMContainingFieldName(e, "foo", true));
+  Expect.throws(() => classMirror.setField(#finalStatic, null),
+                (e) => isNSMContainingFieldName(e, "finalStatic", true));
 
   var instanceMirror = reflect(new A());
   Expect.throws(() => instanceMirror.invoke(#foo, []),
@@ -42,5 +50,61 @@ main() {
                 (e) => isNSMContainingFieldName(e, "foo", false));
   Expect.throws(() => instanceMirror.setField(#foo, null),
                 (e) => isNSMContainingFieldName(e, "foo", true));
+  Expect.throws(() => instanceMirror.setField(#finalInstance, null),
+                (e) => isNSMContainingFieldName(e, "finalInstance", true));
+}
 
+expectMatchingErrors(reflectiveAction, baseAction) {
+  var reflectiveError, baseError;
+  try {
+    reflectiveAction();
+  } catch(e) {
+    reflectiveError = e;
+  }
+  try {
+    baseAction();
+  } catch(e) {
+    baseError = e;
+  }
+  print("\n==Base==\n $baseError");
+  print("\n==Reflective==\n $reflectiveError");
+  Expect.stringEquals(baseError.toString(), reflectiveError.toString());
 }
+
+testMatchingMessages() {
+  var mirrors = currentMirrorSystem();
+  var libMirror = mirrors.findLibrary(#MirrorsTest);
+  expectMatchingErrors(() => libMirror.invoke(#foo, []),
+                       () => foo());
+  expectMatchingErrors(() => libMirror.getField(#foo),
+                       () => foo);
+  expectMatchingErrors(() => libMirror.setField(#foo, null),
+                       () => foo= null);
+  expectMatchingErrors(() => libMirror.setField(#finalTopLevel, null),
+                       () => finalTopLevel= null);
+
+  var classMirror = reflectClass(A);
+  expectMatchingErrors(() => classMirror.invoke(#foo, []),
+                       () => A.foo());
+  expectMatchingErrors(() => classMirror.getField(#foo),
+                       () => A.foo);
+  expectMatchingErrors(() => classMirror.setField(#foo, null),
+                       () => A.foo= null);
+  expectMatchingErrors(() => classMirror.setField(#finalStatic, null),
+                       () => A.finalStatic= null);
+
+  var instanceMirror = reflect(new A());
+  expectMatchingErrors(() => instanceMirror.invoke(#foo, []),
+                       () => new A().foo());
+  expectMatchingErrors(() => instanceMirror.getField(#foo),
+                       () => new A().foo);
+  expectMatchingErrors(() => instanceMirror.setField(#foo, null),
+                       () => new A().foo= null);
+  expectMatchingErrors(() => instanceMirror.setField(#finalInstance, null),
+                       () => new A().finalInstance= null);
+}
+
+main() {
+  testMessageContents();
+  testMatchingMessages(); /// dart2js: ok
+}