Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 325433003: Replace Map with HashMap (Closed)

Created:
6 years, 6 months ago by Brian Wilkerson
Modified:
6 years, 6 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Replace Map with HashMap. I didn't bother with obviously short-lived objects, like those generated in order to produce JSON strings, or with anything in tests, but tried to catch everything else. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37094

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 4 chunks +4 lines, -7 lines 3 comments Download
M pkg/analysis_server/lib/src/context_directory_manager.dart View 5 chunks +5 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 5 chunks +5 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/resource.dart View 2 chunks +5 lines, -4 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Brian Wilkerson
6 years, 6 months ago (2014-06-06 19:24:07 UTC) #1
scheglov
LGTM https://codereview.chromium.org/325433003/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/325433003/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode99 pkg/analysis_server/lib/src/analysis_server.dart:99: final Map<Folder, ContextDirectory> folderMap = new HashMap<Folder, ContextDirectory>(); ...
6 years, 6 months ago (2014-06-06 19:26:46 UTC) #2
Brian Wilkerson
https://codereview.chromium.org/325433003/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/325433003/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode99 pkg/analysis_server/lib/src/analysis_server.dart:99: final Map<Folder, ContextDirectory> folderMap = new HashMap<Folder, ContextDirectory>(); > ...
6 years, 6 months ago (2014-06-06 19:31:50 UTC) #3
Brian Wilkerson
Committed patchset #1 manually as r37094 (presubmit successful).
6 years, 6 months ago (2014-06-06 19:32:08 UTC) #4
Paul Berry
6 years, 6 months ago (2014-06-09 18:05:21 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698