Replace Map with HashMap

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
+import 'dart:collection';
 
 import 'package:analysis_server/src/analysis_logger.dart';
 import 'package:analysis_server/src/channel.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/context_directory_manager.dart';
 import 'package:analysis_server/src/domain_analysis.dart';
 import 'package:analysis_server/src/operation/operation_analysis.dart';
 import 'package:analysis_server/src/operation/operation.dart';
 import 'package:analysis_server/src/operation/operation_queue.dart';
 import 'package:analysis_server/src/protocol.dart';
@@ skipping 70 matching lines @@
   List<RequestHandler> handlers;
 
   /**
    * The current default [DartSdk].
    */
   DartSdk defaultSdk = SHARED_SDK;
 
   /**
    * A table mapping [Folder]s to the [ContextDirectory]s associated with them.
    */
-  final Map<Folder, ContextDirectory> folderMap = <Folder, ContextDirectory>{};
+  final Map<Folder, ContextDirectory> folderMap = new HashMap<Folder, ContextDirectory>();

[scheglov, 2014/06/06 19:26:46]

More than 80 characters.

[Brian Wilkerson, 2014/06/06 19:31:50]

So are a lot of other lines in these two files, but I have wrapped all of the
lines I added.

 
   /**
    * A queue of the operations to perform in this server.
    *
    * Invariant: when this queue is non-empty, there is exactly one pending call
    * to [performOperation] on the event queue.  When this list is empty, there are
    * no calls to [performOperation] on the event queue.
    */
   ServerOperationQueue operationQueue;
 
   /**
    * A set of the [ServerService]s to send notifications for.
    */
-  Set<ServerService> serverServices = new Set<ServerService>();
+  Set<ServerService> serverServices = new HashSet<ServerService>();
 
   /**
    * A table mapping [AnalysisService]s to the file paths for which these
    * notifications should be sent.
    */
-  Map<AnalysisService, Set<String>> analysisServices = <AnalysisService, Set<String>>{};
+  Map<AnalysisService, Set<String>> analysisServices = new HashMap<AnalysisService, Set<String>>();

[scheglov, 2014/06/06 19:26:46]

More than 80 characters.

 
   /**
    * True if any exceptions thrown by analysis should be propagated up the call
    * stack.
    */
   bool rethrowExceptions;
 
   /**
    * Initialize a newly created server to receive requests from and send
    * responses to the given [channel].
@@ skipping 121 matching lines @@
         sendStatusNotification(null);
       }
     }
   }
 
   /**
    * Send status notification to the client. The `contextId` indicates
    * the current context being analyzed or `null` if analysis is complete.
    */
   void sendStatusNotification(String contextId) {
-//    if (contextId == lastStatusNotificationContextId) {
-//      return;
-//    }
-//    lastStatusNotificationContextId = contextId;
     Notification notification = new Notification(NOTIFICATION_STATUS);
     Map<String, Object> analysis = new Map();
     if (contextId != null) {
       analysis['analyzing'] = true;
       // TODO(danrubel): replace contextId with real analysisTarget
       analysis['analysisTarget'] = contextId;
     } else {
       analysis['analyzing'] = false;
     }
     notification.params['analysis'] = analysis;
@@ skipping 212 matching lines @@
 /**
  * An enumeration of the services provided by the server domain.
  */
 class ServerService extends Enum2<ServerService> {
   static const ServerService STATUS = const ServerService('STATUS', 0);
 
   static const List<ServerService> VALUES = const [STATUS];
 
   const ServerService(String name, int ordinal) : super(name, ordinal);
 }