Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 325433003: Replace Map with HashMap (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index 48e7f35484de4eec920bde67c518182b6446a1d3..b3ba14306c39c6c3d3c9624348887e9f045aa6aa 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -5,6 +5,7 @@
library analysis.server;
import 'dart:async';
+import 'dart:collection';
import 'package:analysis_server/src/analysis_logger.dart';
import 'package:analysis_server/src/channel.dart';
@@ -95,7 +96,7 @@ class AnalysisServer {
/**
* A table mapping [Folder]s to the [ContextDirectory]s associated with them.
*/
- final Map<Folder, ContextDirectory> folderMap = <Folder, ContextDirectory>{};
+ final Map<Folder, ContextDirectory> folderMap = new HashMap<Folder, ContextDirectory>();
scheglov 2014/06/06 19:26:46 More than 80 characters.
Brian Wilkerson 2014/06/06 19:31:50 So are a lot of other lines in these two files, bu
/**
* A queue of the operations to perform in this server.
@@ -109,13 +110,13 @@ class AnalysisServer {
/**
* A set of the [ServerService]s to send notifications for.
*/
- Set<ServerService> serverServices = new Set<ServerService>();
+ Set<ServerService> serverServices = new HashSet<ServerService>();
/**
* A table mapping [AnalysisService]s to the file paths for which these
* notifications should be sent.
*/
- Map<AnalysisService, Set<String>> analysisServices = <AnalysisService, Set<String>>{};
+ Map<AnalysisService, Set<String>> analysisServices = new HashMap<AnalysisService, Set<String>>();
scheglov 2014/06/06 19:26:46 More than 80 characters.
/**
* True if any exceptions thrown by analysis should be propagated up the call
@@ -257,10 +258,6 @@ class AnalysisServer {
* the current context being analyzed or `null` if analysis is complete.
*/
void sendStatusNotification(String contextId) {
-// if (contextId == lastStatusNotificationContextId) {
-// return;
-// }
-// lastStatusNotificationContextId = contextId;
Notification notification = new Notification(NOTIFICATION_STATUS);
Map<String, Object> analysis = new Map();
if (contextId != null) {
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/context_directory_manager.dart » ('j') | pkg/analysis_server/lib/src/resource.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698