Generate better ARM code for indexed loads and stores.

Generate better ARM code for indexed loads and stores.

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36584

[zra, 2014-05-23 20:03:24]

lgtm

https://codereview.chromium.org/300513002/diff/1/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/300513002/diff/1/runtime/vm/assembler_arm.cc#...
runtime/vm/assembler_arm.cc:2072: UNREACHABLE(); return kByte;
newline?

https://codereview.chromium.org/300513002/diff/1/runtime/vm/assembler_arm.cc#...
runtime/vm/assembler_arm.cc:2074: UNREACHABLE(); return kByte;
newline?

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1229: const Register base = is_load ? IP
: index;
Maybe assert that array and index can't be IP.

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1261: Register array =
locs()->in(0).reg();
const

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1305: Register result1 =
result_pair->At(0).reg();
const

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1306: Register result2 =
result_pair->At(1).reg();
const

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1479: Register array =
locs()->in(0).reg();
const

[regis, 2014-05-23 20:21:35]

Thanks

https://codereview.chromium.org/300513002/diff/1/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/300513002/diff/1/runtime/vm/assembler_arm.cc#...
runtime/vm/assembler_arm.cc:2072: UNREACHABLE(); return kByte;
On 2014/05/23 20:03:24, zra wrote:
> newline?

Done.

https://codereview.chromium.org/300513002/diff/1/runtime/vm/assembler_arm.cc#...
runtime/vm/assembler_arm.cc:2074: UNREACHABLE(); return kByte;
On 2014/05/23 20:03:24, zra wrote:
> newline?

Done.

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1229: const Register base = is_load ? IP
: index;
On 2014/05/23 20:03:24, zra wrote:
> Maybe assert that array and index can't be IP.

Registers array and index are defined by the register allocator, so that cannot
happen.
But done anyway.

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1261: Register array =
locs()->in(0).reg();
On 2014/05/23 20:03:24, zra wrote:
> const

Done.

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1305: Register result1 =
result_pair->At(0).reg();
On 2014/05/23 20:03:24, zra wrote:
> const

Done.

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1306: Register result2 =
result_pair->At(1).reg();
On 2014/05/23 20:03:24, zra wrote:
> const

Done.

https://codereview.chromium.org/300513002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_arm.cc:1479: Register array =
locs()->in(0).reg();
On 2014/05/23 20:03:24, zra wrote:
> const

Done.

[regis, 2014-05-23 20:22:53]

Committed patchset #2 manually as r36584 (presubmit successful).