Issue 300143002: Change Element offset/client/scroll attributes to be num instead of int

Issue 300143002: Change Element offset/client/scroll attributes to be num instead of int (Closed)

Created:
6 years, 7 months ago by vsm

Modified:
6 years, 7 months ago

Reviewers:
Jacob, blois

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change Element offset/client/scroll attributes to be num instead of int Note, these attributes have changed from int to double in Chrome 36. On Dartium, this breaks us in checked mode. Unfortunately, I cannot easily change the dart.idl to mark these as double - that will break Chrome 34 and 35. For now, I need custom code to mark these as num. We need a better solution. TBR=blois@google.com,jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=36627

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+269 lines, -30 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+73 lines, -12 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	5 chunks	+70 lines, -14 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+107 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsm

Committed patchset #1 manually as r36627 (presubmit successful).

6 years, 7 months ago (2014-05-26 10:49:43 UTC) #2

blois

https://codereview.chromium.org/300143002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/300143002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode1328 tools/dom/templates/html/impl/impl_Element.darttemplate:1328: $if DART2JS Can this not use the private field ...

6 years, 7 months ago (2014-05-27 15:21:14 UTC) #3

vsm

On 2014/05/27 15:21:14, blois wrote: > https://codereview.chromium.org/300143002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate > File tools/dom/templates/html/impl/impl_Element.darttemplate (right): > > https://codereview.chromium.org/300143002/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode1328 > ...

6 years, 7 months ago (2014-05-27 15:30:23 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages