Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 300143002: Change Element offset/client/scroll attributes to be num instead of int (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index fa292d5bc588ed04dfd865696d0fd48914dbbb81..aefb15c62d875ca82d7c475c764d0f48e2e51fc4 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -10272,6 +10272,55 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
*/
ElementEvents get on => new ElementEvents(this);
+ @DomName('Element.offsetHeight')
+ @DocsEditable()
+ final num offsetHeight;
+
+ @DomName('Element.offsetLeft')
+ @DocsEditable()
+ final num offsetLeft;
+
+ @DomName('Element.offsetTop')
+ @DocsEditable()
+ final num offsetTop;
+
+ @DomName('Element.offsetWidth')
+ @DocsEditable()
+ final num offsetWidth;
+
+ @DomName('Element.clientHeight')
+ @DocsEditable()
+ final num clientHeight;
+
+ @DomName('Element.clientLeft')
+ @DocsEditable()
+ final num clientLeft;
+
+ @DomName('Element.clientTop')
+ @DocsEditable()
+ final num clientTop;
+
+ @DomName('Element.clientWidth')
+ @DocsEditable()
+ final num clientWidth;
+
+ @DomName('Element.scrollHeight')
+ @DocsEditable()
+ final num scrollHeight;
+
+ @DomName('Element.scrollLeft')
+ @DocsEditable()
+ num scrollLeft;
+
+ @DomName('Element.scrollTop')
+ @DocsEditable()
+ num scrollTop;
+
+ @DomName('Element.scrollWidth')
+ @DocsEditable()
+ final num scrollWidth;
+
+
// To suppress missing implicit constructor warnings.
factory Element._() { throw new UnsupportedError("Not supported"); }
@@ -10955,21 +11004,25 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
@DocsEditable()
String className;
+ @JSName('clientHeight')
@DomName('Element.clientHeight')
@DocsEditable()
- final int clientHeight;
+ final int _clientHeight;
+ @JSName('clientLeft')
@DomName('Element.clientLeft')
@DocsEditable()
- final int clientLeft;
+ final int _clientLeft;
+ @JSName('clientTop')
@DomName('Element.clientTop')
@DocsEditable()
- final int clientTop;
+ final int _clientTop;
+ @JSName('clientWidth')
@DomName('Element.clientWidth')
@DocsEditable()
- final int clientWidth;
+ final int _clientWidth;
@DomName('Element.id')
@DocsEditable()
@@ -10986,46 +11039,54 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,
// Use implementation from Node.
// final String _namespaceUri;
+ @JSName('offsetHeight')
@DomName('Element.offsetHeight')
@DocsEditable()
- final int offsetHeight;
+ final int _offsetHeight;
+ @JSName('offsetLeft')
@DomName('Element.offsetLeft')
@DocsEditable()
- final int offsetLeft;
+ final int _offsetLeft;
@DomName('Element.offsetParent')
@DocsEditable()
final Element offsetParent;
+ @JSName('offsetTop')
@DomName('Element.offsetTop')
@DocsEditable()
- final int offsetTop;
+ final int _offsetTop;
+ @JSName('offsetWidth')
@DomName('Element.offsetWidth')
@DocsEditable()
- final int offsetWidth;
+ final int _offsetWidth;
@JSName('outerHTML')
@DomName('Element.outerHTML')
@DocsEditable()
final String outerHtml;
+ @JSName('scrollHeight')
@DomName('Element.scrollHeight')
@DocsEditable()
- final int scrollHeight;
+ final int _scrollHeight;
+ @JSName('scrollLeft')
@DomName('Element.scrollLeft')
@DocsEditable()
- int scrollLeft;
+ int _scrollLeft;
+ @JSName('scrollTop')
@DomName('Element.scrollTop')
@DocsEditable()
- int scrollTop;
+ int _scrollTop;
+ @JSName('scrollWidth')
@DomName('Element.scrollWidth')
@DocsEditable()
- final int scrollWidth;
+ final int _scrollWidth;
@DomName('Element.style')
@DocsEditable()

Powered by Google App Engine
This is Rietveld 408576698