tools/dom/scripts/htmlrenamer.py - Issue 300143002: Change Element offset/client/scroll attributes to be num instead of int

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmlrenamer.py

Issue 300143002: Change Element offset/client/scroll attributes to be num instead of int (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('j') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/htmlrenamer.py

diff --git a/tools/dom/scripts/htmlrenamer.py b/tools/dom/scripts/htmlrenamer.py

index c149025bba04abdcac3fd86bdd85248b1e02b64e..126b739abc8da5933d0b6543195c376a06664516 100644

--- a/tools/dom/scripts/htmlrenamer.py

+++ b/tools/dom/scripts/htmlrenamer.py

@@ -237,6 +237,21 @@ private_html_members = monitored.Set('htmlrenamer.private_html_members', [

'Element.hasAttributeNS',

'Element.innerHTML',

'Element.querySelectorAll',

+ # TODO(vsm): These have been converted from int to double in Chrome 36.

+ # Special case them so we run on 34, 35, and 36.

+ 'Element.offsetLeft',

+ 'Element.offsetTop',

+ 'Element.offsetWidth',

+ 'Element.offsetHeight',

+ 'Element.clientLeft',

+ 'Element.clientTop',

+ 'Element.clientWidth',

+ 'Element.clientHeight',

+ 'Element.scrollLeft',

+ 'Element.scrollTop',

+ 'Element.scrollWidth',

+ 'Element.scrollHeight',

'Event.initEvent',

'Geolocation.clearWatch',

'Geolocation.getCurrentPosition',