Issue 295243005: Adds more SIMD instructions to arm64.

Issue 295243005: Adds more SIMD instructions to arm64. (Closed)

Created:
6 years, 7 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds more SIMD instructions to arm64. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=36585

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1197 lines, -197 lines)			Patch
M	runtime/platform/globals.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm64.h	View	1	6 chunks	+85 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_arm64_test.cc	View	1	10 chunks	+436 lines, -81 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View	1	4 chunks	+23 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View	1	4 chunks	+72 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1	5 chunks	+15 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	3 chunks	+13 lines, -26 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1	8 chunks	+405 lines, -55 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1	3 chunks	+147 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/295243005/diff/1/runtime/vm/assembler_arm64.h File runtime/vm/assembler_arm64.h (right): https://codereview.chromium.org/295243005/diff/1/runtime/vm/assembler_arm64.h#newcode865 runtime/vm/assembler_arm64.h:865: fstrs(reg, Address(SP, -1 * sword_bytes, Address::PreIndex)); Use kFloatSize ...

6 years, 7 months ago (2014-05-23 19:50:24 UTC) #2

zra

https://codereview.chromium.org/295243005/diff/1/runtime/vm/assembler_arm64.h File runtime/vm/assembler_arm64.h (right): https://codereview.chromium.org/295243005/diff/1/runtime/vm/assembler_arm64.h#newcode865 runtime/vm/assembler_arm64.h:865: fstrs(reg, Address(SP, -1 * sword_bytes, Address::PreIndex)); On 2014/05/23 19:50:24, ...

6 years, 7 months ago (2014-05-23 20:12:58 UTC) #3

zra

6 years, 7 months ago (2014-05-23 20:34:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36585 (presubmit successful).

Expand Messages | Collapse Messages