Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 28783006: Properly parse friendly stack traces without columns. (Closed)

Created:
7 years, 2 months ago by nweiz
Modified:
7 years, 2 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Properly parse friendly stack traces without columns. Committed: https://code.google.com/p/dart/source/detail?r=28892

Patch Set 1 #

Patch Set 2 : Firefox fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M pkg/stack_trace/lib/src/frame.dart View 1 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/stack_trace/lib/src/trace.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
TBR
7 years, 2 months ago (2013-10-18 22:56:53 UTC) #1
nweiz
Committed patchset #2 manually as r28892 (presubmit successful).
7 years, 2 months ago (2013-10-18 22:57:14 UTC) #2
Alan Knight
7 years, 2 months ago (2013-10-21 19:24:59 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698