pkg/stack_trace/lib/src/trace.dart - Issue 28783006: Properly parse friendly stack traces without columns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/stack_trace/lib/src/trace.dart

Issue 28783006: Properly parse friendly stack traces without columns. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Firefox fixes Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/stack_trace/lib/src/trace.dart

diff --git a/pkg/stack_trace/lib/src/trace.dart b/pkg/stack_trace/lib/src/trace.dart

index bf14ee2fbfac2e1ae9b241244f96dd72af631082..95d41ad47e7effd738c91cb4cb21c591d889dfa5 100644

--- a/pkg/stack_trace/lib/src/trace.dart

+++ b/pkg/stack_trace/lib/src/trace.dart

@@ -36,7 +36,7 @@ final _v8TraceLine = new RegExp(r" ?at ");

final _firefoxTrace = new RegExp(r"^([.0-9A-Za-z_$/<]|$.*$)*@");

/// A RegExp to match this package's stack traces.

-final _friendlyTrace = new RegExp(r"^[^\s]+( \d+:\d+)?\s+[^\s]+($|\n)");

+final _friendlyTrace = new RegExp(r"^[^\s]+( \d+(:\d+)?)?\s+[^\s]+($|\n)");

/// A stack trace, comprised of a list of stack frames.

class Trace implements StackTrace {

« no previous file with comments | « pkg/stack_trace/lib/src/frame.dart ('k') | pkg/stack_trace/test/frame_test.dart » ('j') | no next file with comments »