Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: pkg/stack_trace/test/frame_test.dart

Issue 28783006: Properly parse friendly stack traces without columns. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Firefox fixes Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/stack_trace/lib/src/trace.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/stack_trace/test/frame_test.dart
diff --git a/pkg/stack_trace/test/frame_test.dart b/pkg/stack_trace/test/frame_test.dart
index 62cfd2ee0a2b1b8c0ec997ca1c26fecdb42841bb..4b347c99869f9e67849082676b714095ddcc4e55 100644
--- a/pkg/stack_trace/test/frame_test.dart
+++ b/pkg/stack_trace/test/frame_test.dart
@@ -202,6 +202,18 @@ void main() {
expect(frame.member, equals("foo.<fn>"));
});
+ test('parses a deeply-nested anonymous stack frame with parameters '
+ 'correctly', () {
+ var frame = new Frame.parseFirefox(
+ '.convertDartClosureToJS/\$function</<@'
+ 'http://pub.dartlang.org/stuff.dart.js:560');
+ expect(frame.uri,
+ equals(Uri.parse("http://pub.dartlang.org/stuff.dart.js")));
+ expect(frame.line, equals(560));
+ expect(frame.column, isNull);
+ expect(frame.member, equals("convertDartClosureToJS.<fn>.<fn>"));
+ });
+
test('throws a FormatException for malformed frames', () {
expect(() => new Frame.parseFirefox(''), throwsFormatException);
expect(() => new Frame.parseFirefox('.foo'), throwsFormatException);
« no previous file with comments | « pkg/stack_trace/lib/src/trace.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698