Issue 286973011: Fix register allocator to properly allocate containers.

Issue 286973011: Fix register allocator to properly allocate containers. (Closed)

Created:
6 years, 7 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google), Cutch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix register allocator to properly allocate containers. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=36264

Patch Set 2 : #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -30 lines)			Patch
	M	runtime/vm/flow_graph_allocator.h	View		1 chunk	+3 lines, -2 lines	2 comments	Download
	M	runtime/vm/flow_graph_allocator.cc	View	1	11 chunks	+36 lines, -28 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM w/Q https://codereview.chromium.org/286973011/diff/20001/runtime/vm/flow_graph_allocator.h File runtime/vm/flow_graph_allocator.h (right): https://codereview.chromium.org/286973011/diff/20001/runtime/vm/flow_graph_allocator.h#newcode302 runtime/vm/flow_graph_allocator.h:302: GrowableArray<ZoneGrowableArray<LiveRange*>*> registers_; The array of LiveRange* values ...

6 years, 7 months ago (2014-05-16 18:15:11 UTC) #2

srdjan

https://codereview.chromium.org/286973011/diff/20001/runtime/vm/flow_graph_allocator.h File runtime/vm/flow_graph_allocator.h (right): https://codereview.chromium.org/286973011/diff/20001/runtime/vm/flow_graph_allocator.h#newcode302 runtime/vm/flow_graph_allocator.h:302: GrowableArray<ZoneGrowableArray<LiveRange*>*> registers_; On 2014/05/16 18:15:12, hausner wrote: > The ...

6 years, 7 months ago (2014-05-16 18:21:02 UTC) #3

srdjan

6 years, 7 months ago (2014-05-16 18:21:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r36264 (presubmit successful).

Expand Messages | Collapse Messages