runtime/vm/flow_graph_allocator.h - Issue 286973011: Fix register allocator to properly allocate containers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_allocator.h

Issue 286973011: Fix register allocator to properly allocate containers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_allocator.h

===================================================================

--- runtime/vm/flow_graph_allocator.h (revision 36262)

+++ runtime/vm/flow_graph_allocator.h (working copy)

@@ -298,9 +298,10 @@

// ranges that can be affected by future allocation decisions.

// Those live ranges that end before the start of the current live range are

// removed from the list and will not be affected.

- GrowableArray<LiveRange*> registers_[kNumberOfCpuRegisters];

+ // The length of both arrays is 'number_of_registers_'

+ GrowableArray<ZoneGrowableArray<LiveRange*>*> registers_;

hausner 2014/05/16 18:15:12 The array of LiveRange* values was previously not

srdjan 2014/05/16 18:21:03 Yes, because GrowableArray cannot contain another

- bool blocked_registers_[kNumberOfCpuRegisters];

+ GrowableArray<bool> blocked_registers_;

// Worklist for register allocator. Always maintained sorted according

« no previous file with comments | « no previous file | runtime/vm/flow_graph_allocator.cc » ('j') | no next file with comments »