Fix register allocator to properly allocate containers.

runtime/vm/flow_graph_allocator.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_ALLOCATOR_H_
 #define VM_FLOW_GRAPH_ALLOCATOR_H_
 
 #include "vm/flow_graph.h"
 #include "vm/growable_array.h"
 #include "vm/intermediate_language.h"
@@ skipping 280 matching lines @@
   GrowableArray<Instruction*> safepoints_;
 
   Location::Kind register_kind_;
 
   intptr_t number_of_registers_;
 
   // Per register lists of allocated live ranges.  Contain only those
   // ranges that can be affected by future allocation decisions.
   // Those live ranges that end before the start of the current live range are
   // removed from the list and will not be affected.
-  GrowableArray<LiveRange*> registers_[kNumberOfCpuRegisters];
+  // The length of both arrays is 'number_of_registers_'
+  GrowableArray<ZoneGrowableArray<LiveRange*>*> registers_;

[hausner, 2014/05/16 18:15:12]

The array of LiveRange* values was previously not allocated in a zone. Is that
necessary?

[srdjan, 2014/05/16 18:21:03]

Yes, because GrowableArray cannot contain another growable array.

 
-  bool blocked_registers_[kNumberOfCpuRegisters];
+  GrowableArray<bool> blocked_registers_;
 
 
   // Worklist for register allocator. Always maintained sorted according
   // to ShouldBeAllocatedBefore predicate.
   GrowableArray<LiveRange*> unallocated_;
 
   // List of used spill slots. Contains positions after which spill slots
   // become free and can be reused for allocation.
   GrowableArray<intptr_t> spill_slots_;
 
@@ skipping 348 matching lines @@
 
   AllocationFinger finger_;
 
   DISALLOW_COPY_AND_ASSIGN(LiveRange);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_ALLOCATOR_H_