Update test.dart to tell the analyzer to use the --use-dart2js-libraries flag when analyzing dart2j…

Update test.dart to tell the analyzer to use the --use-dart2js-libraries flag when analyzing dart2js libs.


BUG=
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36189

[Emily Fortuna, 2014-05-14 20:29:31]

This enables the option that Brian added a while back so we can use it while
analyzing dart2js libraries (like html_dart2js.dart) with the analyzer.

[Brian Wilkerson, 2014-05-14 20:33:02]

LGTM

[Emily Fortuna, 2014-05-14 20:34:54]

Committed patchset #2 manually as r36189 (presubmit successful).

[ricow1, 2014-05-15 06:50:10]

https://codereview.chromium.org/286883004/diff/30001/tools/testing/dart/test_...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/286883004/diff/30001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1401: args.add("--use-dart2js-libraries");
this is a major hack and we should try to do this in another way - this will
include files that it is not suppose to.
Which test suites are we exactly trying to do this for?

[Emily Fortuna, 2014-05-15 15:21:56]

https://codereview.chromium.org/286883004/diff/30001/tools/testing/dart/test_...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/286883004/diff/30001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1401: args.add("--use-dart2js-libraries");
On 2014/05/15 06:50:10, ricow1 wrote:
> this is a major hack and we should try to do this in another way - this will
> include files that it is not suppose to.
> Which test suites are we exactly trying to do this for?

Agreed it's a major hack. I didn't know of a nicer way to do so. This is for
analyzing any of the dart2js html files (web_gl_dart2js.dart, html_dart2js.dart
and so on). We have the vague convention of ending in "dart2js" in the filename,
but then also html_common bucks that trend. Brian can come up with some more
examples, but I believe there were others that didn't fit the pattern so well
either, which is why he added the flag to begin with, rather than
"auto-detecting" it was a dart2js lib.