Update test.dart to tell the analyzer to use the --use-dart2js-libraries flag when analyzing dart2j…

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 24b1510503eff4892f3f01f8f91b391180251e71..d7e86b66172d034c9e1b68cf0a19f2e69b361ff4 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1395,6 +1395,12 @@ class StandardTestSuite extends TestSuite {
       args.add('--no-hints');
     }
 
+    if ((configuration["compiler"] == "dartanalyzer" ||
+        configuration["compiler"] == "dart2analyzer") &&
+        filePath.filename.contains("dart2js")) {
+      args.add("--use-dart2js-libraries");

[ricow1, 2014/05/15 06:50:10]

this is a major hack and we should try to do this in another way - this will
include files that it is not suppose to.
Which test suites are we exactly trying to do this for?

[Emily Fortuna, 2014/05/15 15:21:57]

Agreed it's a major hack. I didn't know of a nicer way to do so. This is for
analyzing any of the dart2js html files (web_gl_dart2js.dart, html_dart2js.dart
and so on). We have the vague convention of ending in "dart2js" in the filename,
but then also html_common bucks that trend. Brian can come up with some more
examples, but I believe there were others that didn't fit the pattern so well
either, which is why he added the flag to begin with, rather than
"auto-detecting" it was a dart2js lib.

+    }
+
     bool isMultitest = optionsFromFile["isMultitest"];
     List<String> dartOptions = optionsFromFile["dartOptions"];