Update test.dart to tell the analyzer to use the --use-dart2js-libraries flag when analyzing dart2j…

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 1377 matching lines @@
     String packageRoot = packageRootArgument(optionsFromFile['packageRoot']);
     if (packageRoot != null) {
       args.add(packageRoot);
     }
     args.addAll(additionalOptions(filePath));
     if (configuration['analyzer']) {
       args.add('--machine');
       args.add('--no-hints');
     }
 
+    if ((configuration["compiler"] == "dartanalyzer" ||
+        configuration["compiler"] == "dart2analyzer") &&
+        filePath.filename.contains("dart2js")) {
+      args.add("--use-dart2js-libraries");

[ricow1, 2014/05/15 06:50:10]

this is a major hack and we should try to do this in another way - this will
include files that it is not suppose to.
Which test suites are we exactly trying to do this for?

[Emily Fortuna, 2014/05/15 15:21:57]

Agreed it's a major hack. I didn't know of a nicer way to do so. This is for
analyzing any of the dart2js html files (web_gl_dart2js.dart, html_dart2js.dart
and so on). We have the vague convention of ending in "dart2js" in the filename,
but then also html_common bucks that trend. Brian can come up with some more
examples, but I believe there were others that didn't fit the pattern so well
either, which is why he added the flag to begin with, rather than
"auto-detecting" it was a dart2js lib.

+    }
+
     bool isMultitest = optionsFromFile["isMultitest"];
     List<String> dartOptions = optionsFromFile["dartOptions"];
 
     assert(!isMultitest || dartOptions == null);
     if (dartOptions == null) {
       args.add(filePath.toNativePath());
     } else {
       var executable_name = dartOptions[0];
       // TODO(ager): Get rid of this hack when the runtime checkout goes away.
       var file = new File(executable_name);
@@ skipping 803 matching lines @@
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
  * $compileErrorSkip tests are skipped on browsers due to compile-time error
 """;
     print(report);
   }
 }