Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 28173002: Code review changes for ngeoffray's comments on r28278 (Closed)

Created:
7 years, 2 months ago by sra1
Modified:
7 years, 2 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Code review changes for ngeoffray's comments on r28278 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=29029

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 4 chunks +7 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/lib/interceptors.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_native/subclassing_constructor_1_test.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
7 years, 2 months ago (2013-10-18 04:09:22 UTC) #1
ngeoffray
LGTM! Thank you. https://codereview.chromium.org/28173002/diff/1/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/28173002/diff/1/sdk/lib/html/dartium/html_dartium.dart#oldcode26956 sdk/lib/html/dartium/html_dartium.dart:26956: if ((blob_OR_source_OR_stream is Blob || blob_OR_source_OR_stream ...
7 years, 2 months ago (2013-10-18 08:15:52 UTC) #2
sra1
7 years, 2 months ago (2013-10-22 19:50:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29029 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698