Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: sdk/lib/_internal/lib/interceptors.dart

Issue 28173002: Code review changes for ngeoffray's comments on r28278 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/interceptors.dart
diff --git a/sdk/lib/_internal/lib/interceptors.dart b/sdk/lib/_internal/lib/interceptors.dart
index 151fc3d56d6235eca74e14bf17b247f12047c0e7..bfdbb36b16dae106c533f6ead39251fd251642f1 100644
--- a/sdk/lib/_internal/lib/interceptors.dart
+++ b/sdk/lib/_internal/lib/interceptors.dart
@@ -168,7 +168,7 @@ var interceptedNames;
// TODO(sra): Mark this as initialized to a constant with unknown value.
var mapTypeToInterceptor;
-int findIndexForWebComponentType(Type type) {
+int findIndexForNativeSubclassType(Type type) {
JS_EFFECT((_){ mapTypeToInterceptor = _; });
if (mapTypeToInterceptor == null) return null;
List map = JS('JSFixedArray', '#', mapTypeToInterceptor);
@@ -181,7 +181,7 @@ int findIndexForWebComponentType(Type type) {
}
findInterceptorConstructorForType(Type type) {
- var index = findIndexForWebComponentType(type);
+ var index = findIndexForNativeSubclassType(type);
if (index == null) return null;
List map = JS('JSFixedArray', '#', mapTypeToInterceptor);
return mapTypeToInterceptor[index + 1];
@@ -193,8 +193,8 @@ findInterceptorConstructorForType(Type type) {
*
* The returned function takes one argument, the web component object.
*/
-findConstructorForWebComponentType(Type type, String name) {
- var index = findIndexForWebComponentType(type);
+findConstructorForNativeSubclassType(Type type, String name) {
+ var index = findIndexForNativeSubclassType(type);
if (index == null) return null;
List map = JS('JSFixedArray', '#', mapTypeToInterceptor);
var constructorMap = mapTypeToInterceptor[index + 2];
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/html/dart2js/html_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698