Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

Issue 28173002: Code review changes for ngeoffray's comments on r28278 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_backend; 5 part of js_backend;
6 6
7 /** 7 /**
8 * Support for Custom Elements. 8 * Support for Custom Elements.
9 * 9 *
10 * The support for custom elements the compiler builds a table that maps the 10 * The support for custom elements the compiler builds a table that maps the
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 assert(element.isClass()); 94 assert(element.isClass());
95 assert(!enqueuer.isResolutionQueue); 95 assert(!enqueuer.isResolutionQueue);
96 codegenJoin.selectedClasses.add(element); 96 codegenJoin.selectedClasses.add(element);
97 } 97 }
98 98
99 void registerStaticUse(Element element, Enqueuer enqueuer) { 99 void registerStaticUse(Element element, Enqueuer enqueuer) {
100 assert(element != null); 100 assert(element != null);
101 if (!fetchedTableAccessorMethod) { 101 if (!fetchedTableAccessorMethod) {
102 fetchedTableAccessorMethod = true; 102 fetchedTableAccessorMethod = true;
103 tableAccessorMethod = compiler.findInterceptor( 103 tableAccessorMethod = compiler.findInterceptor(
104 'findIndexForWebComponentType'); 104 'findIndexForNativeSubclassType');
105 } 105 }
106 if (element == tableAccessorMethod) { 106 if (element == tableAccessorMethod) {
107 joinFor(enqueuer).demanded = true; 107 joinFor(enqueuer).demanded = true;
108 } 108 }
109 } 109 }
110 110
111 void onQueueEmpty(Enqueuer enqueuer) { 111 void onQueueEmpty(Enqueuer enqueuer) {
112 joinFor(enqueuer).flush(enqueuer); 112 joinFor(enqueuer).flush(enqueuer);
113 } 113 }
114 114
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 result.add(member); 192 result.add(member);
193 } 193 }
194 } 194 }
195 } 195 }
196 classElement.forEachMember(selectGenerativeConstructors, 196 classElement.forEachMember(selectGenerativeConstructors,
197 includeBackendMembers: false, 197 includeBackendMembers: false,
198 includeSuperAndInjectedMembers: false); 198 includeSuperAndInjectedMembers: false);
199 return result; 199 return result;
200 } 200 }
201 } 201 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698