Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 27694005: Fix issue 13942 - Dart_Error function invokes OS::VSNPrint with the "format" string containing data… (Closed)

Created:
7 years, 2 months ago by siva
Modified:
7 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix issue 13942 - Dart_Error function invokes OS::VSNPrint with the "format" string containing data derived from the string R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -87 lines) Patch
runtime/bin/builtin_nolib.cc View 1 chunk +5 lines, -3 lines 0 comments Download
runtime/bin/dartutils.h View 1 chunk +1 line, -0 lines 0 comments Download
runtime/bin/dartutils.cc View 11 chunks +32 lines, -16 lines 0 comments Download
runtime/bin/extensions.cc View 3 chunks +3 lines, -3 lines 0 comments Download
runtime/bin/gen_snapshot.cc View 4 chunks +5 lines, -5 lines 0 comments Download
runtime/bin/vmservice_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
runtime/include/dart_api.h View 2 chunks +3 lines, -4 lines 0 comments Download
runtime/vm/bootstrap.cc View 3 chunks +6 lines, -6 lines 0 comments Download
runtime/vm/dart_api_impl.cc View 1 chunk +4 lines, -31 lines 0 comments Download
runtime/vm/dart_api_impl_test.cc View 13 chunks +13 lines, -13 lines 0 comments Download
runtime/vm/unit_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 2 months ago (2013-10-17 16:33:09 UTC) #1
Ivan Posva
LGTM -ip
7 years, 2 months ago (2013-10-17 17:02:01 UTC) #2
siva
7 years, 2 months ago (2013-10-17 17:49:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698