Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: runtime/bin/extensions.cc

Issue 27694005: Fix issue 13942 - Dart_Error function invokes OS::VSNPrint with the "format" string containing data… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/bin/gen_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/extensions.cc
===================================================================
--- runtime/bin/extensions.cc (revision 28804)
+++ runtime/bin/extensions.cc (working copy)
@@ -21,7 +21,7 @@
char* library_path = strdup(extension_url);
if (library_path == NULL) {
- return Dart_Error("Out of memory in LoadExtension");
+ return Dart_NewApiError("Out of memory in LoadExtension");
}
// Extract the path and the extension name from the url.
@@ -32,7 +32,7 @@
void* library_handle = LoadExtensionLibrary(library_path, extension_name);
if (library_handle == NULL) {
free(library_path);
- return Dart_Error("cannot find extension library");
+ return Dart_NewApiError("cannot find extension library");
}
const char* strings[] = { extension_name, "_Init", NULL };
@@ -44,7 +44,7 @@
free(library_path);
if (fn == NULL) {
- return Dart_Error("cannot find initialization function in extension");
+ return Dart_NewApiError("cannot find initialization function in extension");
}
return (*fn)(parent_library);
}
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/bin/gen_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698