Fix issue 13942 - Dart_Error function invokes OS::VSNPrint with the "format" string containing data…

runtime/vm/bootstrap.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap.h"
 
 #include "include/dart_api.h"
 
 #include "vm/bootstrap_natives.h"
 #include "vm/compiler.h"
@@ skipping 148 matching lines @@
 }
 
 
 static Dart_Handle LoadPartSource(Isolate* isolate,
                                   const Library& lib,
                                   const String& uri) {
   const String& part_source = String::Handle(
       isolate, GetLibrarySource(lib, uri, false));
   const String& lib_uri = String::Handle(isolate, lib.url());
   if (part_source.IsNull()) {
-    return Dart_NewApiError("Unable to read part file '%s' of library '%s'",
-                            uri.ToCString(), lib_uri.ToCString());
+    return Api::NewError("Unable to read part file '%s' of library '%s'",
+                         uri.ToCString(), lib_uri.ToCString());
   }
 
   // Prepend the library URI to form a unique script URI for the part.
   const Array& strings = Array::Handle(isolate, Array::New(3));
   strings.SetAt(0, lib_uri);
   strings.SetAt(1, Symbols::Slash());
   strings.SetAt(2, uri);
   const String& part_uri = String::Handle(isolate, String::ConcatAll(strings));
 
   // Create a script object and compile the part.
   const Script& part_script = Script::Handle(
       isolate, Script::New(part_uri, part_source, RawScript::kSourceTag));
   const Error& error = Error::Handle(isolate, Compile(lib, part_script));
   return Api::NewHandle(isolate, error.raw());
 }
 
 
 static Dart_Handle BootstrapLibraryTagHandler(Dart_LibraryTag tag,
                                               Dart_Handle library,
                                               Dart_Handle uri) {
   Isolate* isolate = Isolate::Current();
   if (!Dart_IsLibrary(library)) {
-    return Dart_NewApiError("not a library");
+    return Api::NewError("not a library");
   }
   if (!Dart_IsString(uri)) {
-    return Dart_NewApiError("uri is not a string");
+    return Api::NewError("uri is not a string");
   }
   if (tag == Dart_kCanonicalizeUrl) {
     // In the boot strap loader we do not try and do any canonicalization.
     return uri;
   }
   const String& uri_str = Api::UnwrapStringHandle(isolate, uri);
   ASSERT(!uri_str.IsNull());
   if (tag == Dart_kImportTag) {
     // We expect the core bootstrap libraries to only import other
     // core bootstrap libraries.
     // We have precreated all the bootstrap library objects hence
     // we do not expect to be called back with the tag set to kImportTag.
     // The bootstrap process explicitly loads all the libraries one by one.
-    return Dart_NewApiError("Invalid import of '%s' in a bootstrap library",
-                            uri_str.ToCString());
+    return Api::NewError("Invalid import of '%s' in a bootstrap library",
+                         uri_str.ToCString());
   }
   ASSERT(tag == Dart_kSourceTag);
   const Library& lib = Api::UnwrapLibraryHandle(isolate, library);
   ASSERT(!lib.IsNull());
   return LoadPartSource(isolate, lib, uri_str);
 }
 
 
 static RawError* LoadPatchFiles(Isolate* isolate,
                                 const Library& lib,
@@ skipping 98 matching lines @@
   // Exit the Dart scope.
   Dart_ExitScope();
 
   // Restore the library tag handler for the isolate.
   isolate->set_library_tag_handler(saved_tag_handler);
 
   return error.raw();
 }
 
 }  // namespace dart