Issue 27441002: Removing setImmediate and hiding WindowTimers interface (take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27441002: Removing setImmediate and hiding WindowTimers interface (take 2) (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Removing setImmediate and hiding WindowTimers interface"" Issue was that requestAnimationFrame got removed from Dartium during a merge conflict :( BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=28700

Patch Set 1 #

Patch Set 2 : The fix #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -651 lines)			Patch
M	samples/clock/web/clock.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	samples/clock/web/numbers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/solar/web/solar.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	samples/swarm/Views.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/swarm/swarm_ui_lib/touch/Scroller.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/swarm/swarm_ui_lib/view/PagedViews.dart	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	samples/swarm/swarm_ui_lib/view/SliderMenu.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/swarm/swarm_ui_lib/view/view.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	samples/swarm/test/swarm_ui_lib/layout/grid_layout_demo.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samples/swipe/web/swipe.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		6 chunks	+22 lines, -198 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		6 chunks	+37 lines, -213 lines	0 comments	Download
M	tests/html/html.status	View		2 chunks	+0 lines, -2 lines	0 comments	Download
D	tests/html/microtask_test.dart	View		1 chunk	+0 lines, -36 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
D	tools/dom/src/Microtask.dart	View		1 chunk	+0 lines, -156 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1	2 chunks	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 2 months ago (2013-10-16 00:51:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r28700 (presubmit successful).

Expand Messages | Collapse Messages