samples/swarm/swarm_ui_lib/view/view.dart - Issue 27441002: Removing setImmediate and hiding WindowTimers interface (take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/swarm/swarm_ui_lib/view/view.dart

Issue 27441002: Removing setImmediate and hiding WindowTimers interface (take 2) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: The fix Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « samples/swarm/swarm_ui_lib/view/SliderMenu.dart ('k') | samples/swarm/test/swarm_ui_lib/layout/grid_layout_demo.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: samples/swarm/swarm_ui_lib/view/view.dart

diff --git a/samples/swarm/swarm_ui_lib/view/view.dart b/samples/swarm/swarm_ui_lib/view/view.dart

index efa9501168ee820a164fde582c06012289a6c779..9c34b14c363752b7128fcd653a2ce5c84ce09851 100644

--- a/samples/swarm/swarm_ui_lib/view/view.dart

+++ b/samples/swarm/swarm_ui_lib/view/view.dart

@@ -338,7 +338,7 @@ class View implements Positionable {

changedComplete = true;

});

- window.setImmediate(() {

+ scheduleMicrotask(() {

if (!changedComplete) {

changed.complete(false);

}

@@ -355,7 +355,7 @@ class View implements Positionable {

if (ViewLayout.hasCustomLayout(this)) {

// TODO(10459): code should not use Completer.sync.

Completer sizeCompleter = new Completer<Size>.sync();

- window.setImmediate(() {

+ scheduleMicrotask(() {

sizeCompleter.complete(

new Size(_node.client.width, _node.client.height));

});

« no previous file with comments | « samples/swarm/swarm_ui_lib/view/SliderMenu.dart ('k') | samples/swarm/test/swarm_ui_lib/layout/grid_layout_demo.dart » ('j') | no next file with comments »