Assume a method can be torn off, if it's accessible through reflection.

Assume a method can be torn off, if it's accessible through reflection.

BUG= http://dartbug.com/18673
R=herhut@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35962

[herhut, 2014-05-08 14:21:55]

LGTM w comment

https://codereview.chromium.org/273723003/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
(right):

https://codereview.chromium.org/273723003/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart:381:
compiler.codegenWorld.staticFunctionsNeedingGetter.contains(member) ||
long line

[floitsch, 2014-05-08 15:40:14]

https://codereview.chromium.org/273723003/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
(right):

https://codereview.chromium.org/273723003/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart:381:
compiler.codegenWorld.staticFunctionsNeedingGetter.contains(member) ||
On 2014/05/08 14:21:55, herhut wrote:
> long line

Not for me.

[floitsch, 2014-05-08 18:23:28]

PTAL.

@Karl, Johnni: is there a better way to know if an element is an operator?

[floitsch, 2014-05-09 07:02:21]

More tests and fixes.

[Johnni Winther, 2014-05-09 07:04:25]

lgtm

[herhut, 2014-05-09 07:23:18]

https://codereview.chromium.org/273723003/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
(right):

https://codereview.chromium.org/273723003/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart:351:
return Elements.operatorNameToIdentifier(member.name) != member.name;
Why do we use two different ways to determine whether it is an operator?

https://codereview.chromium.org/273723003/diff/60001/sdk/lib/_internal/compil...
File
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart
(right):

https://codereview.chromium.org/273723003/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart:110:
} else if (simpleName.startsWith('operator\$')) {
Why does this not use the simpleName != function.name method here?

[floitsch, 2014-05-09 07:53:19]

https://codereview.chromium.org/273723003/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
(right):

https://codereview.chromium.org/273723003/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart:351:
return Elements.operatorNameToIdentifier(member.name) != member.name;
On 2014/05/09 07:23:18, herhut wrote:
> Why do we use two different ways to determine whether it is an operator?

I didn't want to change unrelated code.

https://codereview.chromium.org/273723003/diff/60001/sdk/lib/_internal/compil...
File
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart
(right):

https://codereview.chromium.org/273723003/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart:110:
} else if (simpleName.startsWith('operator\$')) {
On 2014/05/09 07:23:18, herhut wrote:
> Why does this not use the simpleName != function.name method here?

I wanted to keep the CL focused.
We will fix this part in a different CL (either by doing the same check as in
the container_builder, or by using the fix of issue 18740 which should add an
isOperator getter to the element).

[floitsch, 2014-05-09 07:55:56]

Committed patchset #4 manually as r35962 (presubmit successful).