Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart

Issue 273723003: Assume a method can be torn off, if it's accessible through reflection. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: More test and fixes. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart
diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart
index f91014aea99d6dcdde78c403d6e2384dcce941cd..be9fa8c365b2a3fb87a2ff3870f1f3889c25469e 100644
--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart
+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart
@@ -108,6 +108,7 @@ class Dart2JsMethodMirror extends Dart2JsMemberMirror
// Simple name is 'unary-'.
simpleName = 'unary-';
} else if (simpleName.startsWith('operator\$')) {
herhut 2014/05/09 07:23:18 Why does this not use the simpleName != function.n
floitsch 2014/05/09 07:53:19 I wanted to keep the CL focused. We will fix this
+ // TODO(18740, johnniwinther): this fails for methods like `operator$foo`.
String str = simpleName.substring(9);
simpleName = 'operator';
kind = Dart2JsMethodKind.OPERATOR;

Powered by Google App Engine
This is Rietveld 408576698