Issue 271193002: Avoid prototype properties in JS-Object caches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271193002: Avoid prototype properties in JS-Object caches. (Closed)

Created:
6 years, 7 months ago by floitsch

Modified:
6 years, 7 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Avoid prototype properties in JS-Object caches. Make sure to create caches with Object.create. BUG= http://dartbug.com/18754 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=36037

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -13 lines)			Patch
M	sdk/lib/_internal/lib/js_helper.dart	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/lib/mirrors/get_field_cache_test.dart	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
A +	tests/lib/mirrors/invocation_cache_test.dart	View	1	1 chunk	+7 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

floitsch

6 years, 7 months ago (2014-05-12 15:50:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r36037 (presubmit successful).