Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tests/lib/mirrors/get_field_cache_test.dart

Issue 271193002: Avoid prototype properties in JS-Object caches. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use Object.create Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/lib/js_mirrors.dart ('k') | tests/lib/mirrors/invocation_cache_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/get_field_cache_test.dart
diff --git a/tests/lib/mirrors/get_field_cache_test.dart b/tests/lib/mirrors/get_field_cache_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..4c71dbc033122a034bf60dd5cbdb76bbd4b873e9
--- /dev/null
+++ b/tests/lib/mirrors/get_field_cache_test.dart
@@ -0,0 +1,36 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+@MirrorsUsed(targets: const ["A", "B"])
+import 'dart:mirrors';
+
+import 'package:expect/expect.dart';
+
+class A {
+ toString() => "A";
+}
+
+class B {
+ int x = 99;
+ toString() => "B";
+}
+
+void main() {
+ var a = new A();
+ var am = reflect(a);
+ for (int i = 0; i < 10; i++) {
+ // Adds a probe function on the symbol.
+ am.getField(#toString);
+ }
+ var b = new B();
+ var bm = reflect(b);
+ for (int i = 0; i < 10; i++) {
+ // Adds a field-cache on the mirror.
+ bm.getField(#x);
+ }
+ // There is a cache now, but the cache should not contain 'toString' from
+ // JavaScript's Object.prototype.
+ var toString = bm.getField(#toString).reflectee;
+ Expect.equals("B", toString());
+}
« no previous file with comments | « sdk/lib/_internal/lib/js_mirrors.dart ('k') | tests/lib/mirrors/invocation_cache_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698