sdk/lib/_internal/lib/js_mirrors.dart - Issue 271193002: Avoid prototype properties in JS-Object caches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 271193002: Avoid prototype properties in JS-Object caches. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use Object.create Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/lib/js_mirrors.dart

diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart

index e7ebddbf3807b940a1673af306f5001fa38cbf14..fdf7393699479f76066cc22426c3694580373ece 100644

--- a/sdk/lib/_internal/lib/js_mirrors.dart

+++ b/sdk/lib/_internal/lib/js_mirrors.dart

@@ -1064,7 +1064,7 @@ class JsInstanceMirror extends JsObjectMirror implements InstanceMirror {

var cache = _getterCache;

if (isMissingCache(cache)) {

if ((_getterCache = --cache) != 0) return result;

- cache = _getterCache = JS('=Object', '({})');

+ cache = _getterCache = JS('=Object', 'Object.create(null)');

}

// Make sure that symbol [fieldName] has a cache probing function ($p).

« no previous file with comments | « sdk/lib/_internal/lib/js_helper.dart ('k') | tests/lib/mirrors/get_field_cache_test.dart » ('j') | no next file with comments »