|
Add pause/resume for isolates in vmservice/observatory.
Improve the isolate view and isolate summary.
Details:
- Rig DbgMsgQueueList so it can run even when the debugger hasn't started.
- Add <action-link> element for pause/resume actions.
- Introduce new flex-percentile css classes.
- Add <isolate-run-state>, <isolate-location>, <isolate-shared-summary>, and <isolate-counter-chart> elements. Counters are now displayed as a pie chart instead of as text.
- Reorg <isolate-view> and <isolate-summary> substantially.
- Add shared style sheet to <script-view>.
- Combine pause-on-start/pause-on-exit with other debugger pause events and present a consistent representation for these in the vm service. Reorg how pause events are shown in <isolate-run-state>.
- Give the user a nicer message when an isolate is still loading.
- Move the /resume command to /debug/resume. Implement this with a bool in the Isolate class which is used to smuggle resume requests from the vm service to the dart embedding api.
- Add the /debug/pause command to the vm service
- Break the DebuggerEvent struct out into its own top-level class. Add JSON printing.
etc.
R=johnmccutchan@google.com
Committed: https://code.google.com/p/dart/source/detail?r=36366
Total comments: 5
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+7629 lines, -6707 lines) |
Patch |
|
M |
runtime/bin/dbg_connection.h
|
View
|
1
2
3
4
5
6
|
2 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/dbg_connection.cc
|
View
|
1
2
3
4
5
6
|
3 chunks |
+18 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/bin/main.cc
|
View
|
4
5
6
|
2 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/bin/resources_sources.gypi
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/index.html
|
View
|
1
2
3
4
5
6
|
8 chunks |
+344 lines, -299 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js
|
View
|
1
2
3
4
5
6
|
484 chunks |
+3004 lines, -2812 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/index_devtools.html
|
View
|
1
2
3
4
5
6
|
8 chunks |
+344 lines, -299 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js
|
View
|
1
2
3
4
5
6
|
485 chunks |
+2997 lines, -2806 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/packages/observatory/elements.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
A + |
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/action_link.html
|
View
|
1
2
3
4
5
6
|
2 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/css/shared.css
|
View
|
1
2
3
4
5
6
|
2 chunks |
+49 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html
|
View
|
1
2
3
4
5
6
|
2 chunks |
+158 lines, -47 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_view.html
|
View
|
1
2
3
4
5
6
|
4 chunks |
+37 lines, -125 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/nav_bar.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_view.html
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/elements.dart
|
View
|
4
5
6
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/elements.html
|
View
|
4
5
6
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
A + |
runtime/bin/vmservice/client/lib/src/elements/action_link.dart
|
View
|
1
4
5
6
|
1 chunk |
+9 lines, -11 lines |
0 comments
|
Download
|
|
A + |
runtime/bin/vmservice/client/lib/src/elements/action_link.html
|
View
|
1
2
3
4
5
6
|
2 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/elements/css/shared.css
|
View
|
4
5
6
|
2 chunks |
+49 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/elements/heap_profile.dart
|
View
|
1
2
3
4
5
6
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/elements/isolate_summary.dart
|
View
|
1
4
5
6
|
1 chunk |
+93 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html
|
View
|
1
2
3
4
5
6
|
2 chunks |
+158 lines, -47 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart
|
View
|
4
5
6
|
1 chunk |
+16 lines, -7 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/elements/isolate_view.html
|
View
|
1
2
3
4
5
6
|
4 chunks |
+37 lines, -125 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/elements/nav_bar.html
|
View
|
4
5
6
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/elements/script_inset.dart
|
View
|
4
5
6
|
1 chunk |
+9 lines, -7 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/elements/script_view.html
|
View
|
4
5
6
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
runtime/bin/vmservice/client/lib/src/service/object.dart
|
View
|
1
2
3
4
5
6
|
4 chunks |
+11 lines, -7 lines |
0 comments
|
Download
|
|
M |
runtime/vm/dart_api_impl.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
runtime/vm/debugger.h
|
View
|
1
4
5
6
|
5 chunks |
+71 lines, -22 lines |
0 comments
|
Download
|
|
M |
runtime/vm/debugger.cc
|
View
|
1
2
4
5
6
|
10 chunks |
+55 lines, -18 lines |
0 comments
|
Download
|
|
M |
runtime/vm/debugger_api_impl.cc
|
View
|
1
4
5
6
|
2 chunks |
+17 lines, -16 lines |
0 comments
|
Download
|
|
M |
runtime/vm/debugger_test.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/isolate.h
|
View
|
1
2
3
4
5
6
|
2 chunks |
+14 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/vm/isolate.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+18 lines, -10 lines |
0 comments
|
Download
|
|
M |
runtime/vm/json_stream.h
|
View
|
4
5
6
|
5 chunks |
+13 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/vm/json_stream.cc
|
View
|
1
4
5
6
|
2 chunks |
+18 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/vm/message_handler.h
|
View
|
1
4
5
6
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/vm/service.cc
|
View
|
1
2
3
4
5
6
|
4 chunks |
+47 lines, -22 lines |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|