Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/action_link.dart

Issue 271153002: Add pause/resume for isolates in vmservice/observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/action_link.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/eval_link.dart b/runtime/bin/vmservice/client/lib/src/elements/action_link.dart
similarity index 55%
copy from runtime/bin/vmservice/client/lib/src/elements/eval_link.dart
copy to runtime/bin/vmservice/client/lib/src/elements/action_link.dart
index be08b76237e2ea09cad27386b3e241f3225ea821..2a1dc935d67201e98dd422ab60b55aa5ea40bb02 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/eval_link.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/action_link.dart
@@ -2,30 +2,28 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library eval_link_element;
+library action_link_element;
import 'package:observatory/service.dart';
import 'package:polymer/polymer.dart';
-@CustomTag('eval-link')
-class EvalLinkElement extends PolymerElement {
- EvalLinkElement.created() : super.created();
+@CustomTag('action-link')
+class ActionLinkElement extends PolymerElement {
+ ActionLinkElement.created() : super.created();
@observable bool busy = false;
@published var callback = null;
- @published String expr = '';
- @published ServiceObject result = null;
+ @published String label = 'action';
- void evalNow(var a, var b, var c) {
+ void doAction(var a, var b, var c) {
if (busy) {
return;
}
if (callback != null) {
busy = true;
- result = null;
- callback(expr).then((ServiceObject obj) {
- result = obj;
- }).whenComplete(() {
+ // TODO(turnidge): Track down why adding a dummy argument makes
+ // this work but having a no-argument callback doesn't.
+ callback(null).whenComplete(() {
busy = false;
});
}
« no previous file with comments | « runtime/bin/vmservice/client/lib/elements.html ('k') | runtime/bin/vmservice/client/lib/src/elements/action_link.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698