runtime/bin/vmservice/client/lib/src/elements/script_inset.dart - Issue 271153002: Add pause/resume for isolates in vmservice/observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/script_inset.dart

Issue 271153002: Add pause/resume for isolates in vmservice/observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/nav_bar.html ('k') | runtime/bin/vmservice/client/lib/src/elements/script_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/elements/script_inset.dart

diff --git a/runtime/bin/vmservice/client/lib/src/elements/script_inset.dart b/runtime/bin/vmservice/client/lib/src/elements/script_inset.dart

index f2a54ba7e6e7cc776d21e875db4f80d19c57870c..da7935296195911515a00ab273c02b1fcc4b3662 100644

--- a/runtime/bin/vmservice/client/lib/src/elements/script_inset.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/script_inset.dart

@@ -64,13 +64,15 @@ class ScriptInsetElement extends ObservatoryElement {

notifyPropertyChange(#lines, 0, 1);

lines.clear();

var startLineNumber = script.tokenToLine(pos);

- if (endPos == null) {

- lines.add(script.lines[startLineNumber - 1]);

- } else {

- var endLineNumber = script.tokenToLine(endPos);

- assert(endLineNumber != null);

- for (var i = startLineNumber; i <= endLineNumber; i++) {

- lines.add(script.lines[i - 1]);

+ if (startLineNumber != null) {

+ if (endPos == null) {

+ lines.add(script.lines[startLineNumber - 1]);

+ } else {

+ var endLineNumber = script.tokenToLine(endPos);

+ assert(endLineNumber != null);

+ for (var i = startLineNumber; i <= endLineNumber; i++) {

+ lines.add(script.lines[i - 1]);

+ }

}